On 18/02/12 04:44 PM, Chandler Carruth wrote: > Sorry for delay.... =[ > > Anyways, this looks really cool. A few super minor points. Only the > first one really matters, check in whenever.
r150898. > 1) Can we get a name without the 'ccc' in it? This is something that I > think users might actually need when cross compiling, so much like > '-target' I'd like it to be an exposed and supported aspect of the > driver. --gcc-toolchain (or a fewer number of dashes as folks like) > seems fine. I went with -gcc-toolchain to match -target. > 2) Is there no PathV2 routine that can remove extraneous '/'s from a > path? Maybe we should add one if not... I couldn't find anything that worked with StringRef. > 3) Should we instead of adding a new test, just fold these cases into > the existing header search and ld invocation tests? Meh, either way, > it's not a big deal. Cheers, Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
