On Tue, May 1, 2012 at 4:51 PM, Andrew Trick <[email protected]> wrote:
> On May 1, 2012, at 2:58 PM, Richard Smith <[email protected]> > wrote: > > > Author: rsmith > > Date: Tue May 1 16:58:31 2012 > > New Revision: 155951 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=155951&view=rev > > Log: > > Fix RecursiveASTVisitor's data recursion to call the Traverse* functions > if they > > have been overridden in the derived class. Also, remove a non-functional > > implementation of an incorrect optimization for ParenExprs. > > > > Modified: > > cfe/trunk/include/clang/AST/RecursiveASTVisitor.h > > cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cpp > > > > Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h > > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=155951&r1=155950&r2=155951&view=diff > > > ============================================================================== > > Richard, > > I had to revert this because the following test failure was blocking other > tests. Let me know if you need more details in order to fix it. > I see why this test was failing: libclang's BodyIndexer overrides TraverseCXXOperatorCallExpr. So the original change which introduced this test had actually broken part of libclang, which this patch fixed. Do you have any objection to me reinstating my change and disabling this test?
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
