On Wed, May 2, 2012 at 10:54 PM, Evan Pipho <[email protected]> wrote: > I am assuming you meant my comments for get_cursors in the test utils. If > so, fixed.
Also, the brief comment at the top both in utils.py and cindex.py. Looking around the surrounding methods seem to have a '.' in the end, so I think new code should follow the example... Cheers, /Manuel > > > On Wed, May 2, 2012 at 10:23 AM, Manuel Klimek <[email protected]> wrote: >> >> Looks good. >> >> Very minor nit: Comments are easier to read (IMO) if you're adding a >> '.' when you have a full sentence. >> >> On Tue, May 1, 2012 at 7:37 AM, Evan P <[email protected]> wrote: >> > When I was writing tests for the original version of this patch I >> > discovered >> > that clang_getCursorLexicalParent was actually broken for some edge >> > cases. >> > Now that my patch for that issue was committed in r155858, lets try this >> > again. >> > >> > - Adding lexical_parent and semantic_parent properties to >> > clang.cindex.Cursor >> > - Two new tests (one for each property), require libclang built from >> > r155858 >> > or later to pass >> > - New test utility function (get_cursors) that gets all the nodes with a >> > specific spelling. >> > >> > >> > Thanks >> > -Evan Pipho >> > >> > >> > >> > _______________________________________________ >> > cfe-commits mailing list >> > [email protected] >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
