Updated test expectations in test/CodeGenCXX/microsoft-abi-static-initializers.cpp to account for the thiscall convention.
On Fri, May 11, 2012 at 5:58 PM, Timur Iskhodzhanov <[email protected]> wrote: > Hi John, > > Can you please review the attached patch? > > In two words what it does is > it overrides the CC_Default calling convention with > context.getDefaultMethodCallConv() > for all the used method definitions and calls. > > What I personally don't like is that the method declarations are > stored with CC_Default and we have to replace that with > context.getDefaultMethodCallConv() wherever we use it. > Unfortunately, we can't change the CC in the global declarations storage. > I'd prefer to put the declarations into the storage with the right CC > but not sure: > a) if we should do it > b) how to do it > c) it's possible at all > > OTOH, it looks like there are only two places we need to alter the > calling convention: method call and method definition :) > So maybe I'm trying too hard to generalize... > > Looking forward for your review and suggestions! > > Thanks, > Timur Iskhodzhanov, > Google Russia
bug_12785_2.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
