On Tue, Jul 17, 2012 at 12:03 AM, Benjamin Kramer <[email protected]> wrote: > > On 16.07.2012, at 21:32, Simon Atanasyan <[email protected]> wrote: >> BTW Benjamin, if I send a patch for review and do not get any >> objections, is it okay to commit this patch in a week? Should I >> continue to ping until I get any reply? > > In general it is not okay to just commit things when there are no replies. > I know how annoying this can be, and there are people working on > getting a better process for reviews for llvm and clang eventually. > > For patches that don't touch other targets and contain test cases, like > this one, I'd suggest getting review from your mips peers, they > know the target best. > > I admit that I screwed this one up, I wanted to comment on your patch > earlier but forgot about it. If you know someone who has worked in the > specific code area recently, feel free to ping them in person. Most of > us are busy enough in their daily routine so things get lost in the noise > of cfe-commits but we won't be mad if reminded.
Thanks for the detailed answer. The procedure looks reasonable and I will follow it. -- Simon _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
