On Thu, Sep 6, 2012 at 9:03 PM, João Matos <[email protected]> wrote: > I actually liked the patch you posted on IRC better. It modified the > mangling while it was being stored on FunctionType, which means mangling > code (and code gen?) don't need to me modified. This one is duplicating the > same logic in both mangling and code-gen.
It didn't modify the mangling because it wasn't making any modifications on the FunctionType. Also, pushing the calling convention information into the TargetInfo hierarchy wasn't the right move because the TargetInfo doesn't always have enough context information to make the decision. That's why we decided to ditch it. So yes, this is duplicating the logic in two places which is a bummer. But I've not found a satisfactory central location for where calling convention semantics should live. ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
