Hi Logan,
Very appreciate for your review. I addressed the first item: Keep the void* test in builtins-arm.c for apcs-gnu ABI Please review the attached patch. For adding the name mangling test case, I already included one (test/CodeGenCXX/mangle-valist.cpp) in my previous patch. Do you mean something else? Thanks a lot, Weiming Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From: Logan Chien [mailto:[email protected]] Sent: Tuesday, October 02, 2012 10:34 PM To: Weiming Zhao Cc: Jordan Rose; [email protected] Subject: Re: [cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4 LGTM. However, I think we can enhance the test cases a little. 1. Keep the void* test in builtins-arm.c for apcs-gnu ABI. 2. Add the unit test for va_list name mangling. Sincerely, Logan ps. The attached patch is the revised patch with the updated test cases. On Thu, Sep 20, 2012 at 6:13 AM, Weiming Zhao <[email protected]> wrote: Ping... Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
0003-Fix-PR-11709-Change-the-definition-of-va_list-to-mee.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
