Apart from my two nits looks good.
================ Comment at: unittests/AST/SourceLocationTest.cpp:38 @@ +37,3 @@ + const MatcherType &AMatcher, Language L); + + virtual void run(const MatchFinder::MatchResult &Result); ---------------- Can all methods after here be protected? ================ Comment at: unittests/AST/SourceLocationTest.cpp:99 @@ +98,3 @@ +/// By default, Node.getSourceLocation() is checked. This can be changed +/// by overriding getLocation(). +template <typename NodeType> ---------------- Are you already seeing a use case for this (as in: one of the next patches you do will use this) or is this purely speculative? http://llvm-reviews.chandlerc.com/D72 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
