On Mon, Oct 29, 2012 at 5:00 PM, Jordan Rose <jordan_r...@apple.com> wrote: > > On Oct 29, 2012, at 13:25 , Eli Friedman <eli.fried...@gmail.com> wrote: > >> On Sun, Oct 28, 2012 at 1:52 PM, Grzegorz Jablonski <grzej...@gmail.com> >> wrote: >>> On 10/28/2012 09:04 PM, Eli Friedman wrote: >>>> >>>> On Sun, Oct 28, 2012 at 3:41 AM, Grzegorz Jablonski <grzej...@gmail.com> >>>> wrote: >>>>> >>>>> On 10/28/2012 03:45 AM, Eli Friedman wrote: >>>>>> >>>>>> We shouldn't be printing "operator const char*" in the first place. >>>>> >>>>> OK, revised patch. >>>> >>>> Please use CastExpr::getSubExprAsWritten. >>>> >>> Like that? >> >> (Adding cfe-commits to the CC list.) >> >> It's a bit scary that this affects CFG dumping. Can someone who knows >> that code take a look? > > Yeah, this is definitely not desireable, even if it is just a debugging > feature. PrinterHelpers allow us to do something special when printing a > certain expression, and the helper might want to see one ImplicitCastExpr > inside another. > > I'm not sure what the correct answer is now. Maybe the CFG printer is using > the wrong PrintingPolicy anyway, but just skipping over implicit nodes seems > scary.
Hmm, yes... if we really need to provide the PrinterHelper a chance to react at every node, then this patch won't work as-is. Unfortunately, there isn't any way to tell at the moment whether a CXXMemberCallExpr is implicit (except maybe getRParenLoc().isValid()?); similarly for MemberExpr. Given that, this would become rather messy. That said, I think the CFG printer probably shouldn't be pretty-printing expressions in the first place. It certainly shouldn't be depending on the StmtPrinter to reliably hand every sub-expression back, if only because that could obscure the actual CFG datastructure. -Eli _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
