Re: [cfe-commits] r168267 - in /cfe/trunk: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Lex/Preprocessor.h lib/Lex/PPMacroExpansion.cpp lib/Lex/Pragma.cpp lib/Lex/Preprocessor.cpp lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX.cpp lib/Parse/Parser.cpp test/Lexer/pragma-message.c test/Parser/attr-availability.c test/Preprocessor/pragma_diagnostic.c test/Preprocessor/pragma_microsoft.c test/Preprocessor/warning_tests.c test/Sema/static-assert.c

[Dmitri Gribenko]

On Sat, Nov 17, 2012 at 9:16 PM, Andy Gibbs <andyg1...@hotmail.co.uk> wrote:
> --- cfe/trunk/lib/Lex/Pragma.cpp (original)
> +++ cfe/trunk/lib/Lex/Pragma.cpp Sat Nov 17 13:16:52 2012
> @@ -503,6 +503,7 @@
>    Lex(Tok);
>    std::string ArgumentString;
>    if (Tok.is(tok::comma) && !LexStringLiteral(Tok, ArgumentString,
> +                                              "pragma comment",
>                                                /*MacroExpansion=*/true))

Hi Andy,

Does it make sense to sink the word 'pragma' into the message itself?
The text "in %1" in the diagnostic is not an optimal solution IMHO.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <griboz...@gmail.com>*/
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits