LGTM.

  About the tests, I can not think of a good way to test this, since 
has_colors() boils down to isatty(fd).

http://llvm-reviews.chandlerc.com/D127
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to