Hi, Do you mean that it will be better to commit the attached patch to LLVM, and revert this commit (r168309) from Clang?
I'm not sure if whether it is a good idea or not. For ARM, it is clear that when we are using AAPCS ABI then we should use .init_array. But on X86 and MIPS, it is difficult to decide whether we should use .init_array or not. This is the reason why -use-init-array option was added. On the other hand, I agree that fixing this issue in LLVM side gives an advantage that all programming language using @llvm.global_ctors can work on Android without the -use-init-array option. I'm OK with both options. What do you think? Thanks. Sincerely, Logan On Wed, Nov 21, 2012 at 7:44 AM, Anton Korobeynikov <[email protected] > wrote: > Yes, right, but enabled differently. My point is maybe we should use > that "different way" instead? > > On Tue, Nov 20, 2012 at 10:21 AM, Logan Chien <[email protected]> > wrote: > > Maybe my wordings are not very good. In fact, this patch enables > > .init_array for every android targets. I only listed MIPS and x86, > because > > ARM has used .init_array before this commit. Thanks. > > > > Logan > > > > > > > > On Tue, Nov 20, 2012 at 9:55 AM, Anton Korobeynikov > > <[email protected]> wrote: > >> > >> Hi Logan, > >> > >> > Enable -fuse-init-array for Android X86/MIPS. > >> Can't we make this default in the backend for all android targets? > >> > >> -- > >> With best regards, Anton Korobeynikov > >> Faculty of Mathematics and Mechanics, Saint Petersburg State University > > > > > > > > -- > With best regards, Anton Korobeynikov > Faculty of Mathematics and Mechanics, Saint Petersburg State University >
0001-Enable-UseInitArray-in-android-environment.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
