================ Comment at: llvm/tools/clang/lib/CodeGen/BackendUtil.cpp:166 @@ -165,1 +165,3 @@ +static cl::opt<bool> ClMSanMoreOpt( + "msan-more-opt", ---------------- Kostya Serebryany wrote: > this bit is questionable. > I remember that all the optimizations below give large speedup (30%?), > but it's unclear if we need all of them. > And I am not sure if using this flag is the best option. > So, maybe remove this part from this CL and commit it separately later? Yea, and if we go this route it should be a prop per clang option. I don't think there is really any of the llvm style options in clang...
================ Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticDriverKinds.td:105 @@ -104,1 +104,3 @@ +def err_drv_tsan_msan_require_pie : Error< + "ThreadSanitizer and MemorySanitizer require '-pie'">; def err_drv_unknown_objc_runtime : Error< ---------------- Diagnostics in clang should be precise by using a select expression to say *exactly* what didn't work (tsan or msan here). http://llvm-reviews.chandlerc.com/D146 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
