I think we might want to come up with more tests that trigger the corner
cases of the memoization.
================
Comment at: lib/Format/Format.cpp:300
@@ +299,3 @@
+ // previous result unless we have hit the optimatization (and thus
+ // returned UINT_MAX) and are now computing for a lower StopAt.
+ unsigned SavedResult = I->second.first;
----------------
s/lower/higher/
================
Comment at: lib/Format/Format.cpp:298
@@ +297,3 @@
+ if (I != Memory.end()) {
+ // If this state has already been examined, we can safely return the
+ // previous result unless we have hit the optimatization (and thus
----------------
I think it would be easier for me to read if this were written positively,
instead of with "unless".
http://llvm-reviews.chandlerc.com/D172
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
