================
Comment at: cpp11-migrate/Cpp11Migrate.cpp:39
@@ +38,3 @@
+// Helper RAII class for created Transforms.
+class TransformVec {
+public:
----------------
Instead of making this a vector-like-but-not-quite class, I'd do
class Transforms {
public:
~Transforms();
void add(Transform *T);
bool applyAll(...);
};
You can also pull more of main()'s functionality into that class if you'd like,
and perhaps find a better name.
================
Comment at: cpp11-migrate/Cpp11Migrate.cpp:88
@@ +87,3 @@
+ bool,
+ cl::parser<TransformCreator> > TransformCLList;
+
----------------
I have no idea what "CL" stands for in TransformCLList...
================
Comment at: cpp11-migrate/Cpp11Migrate.cpp:100
@@ +99,3 @@
+
+ AddTransformOpt<LoopConvertTransform>(TransformList, "loop-convert",
+ "Make use of range-based for loops where possible");
----------------
I don't quite see how this is better from having a bool option per transform...
Anything I'm missing?
http://llvm-reviews.chandlerc.com/D251
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
