On Dec 29, 2012, at 6:48 AM, Timur Iskhodzhanov <[email protected]> wrote: > Please review the new patch attached. > > I've put an extra FIXME for the RTTI handling > and added a new check to the constructor CodeGen test.
Sorry about the delay. Instead of repeating Context.getTargetInfo().getCXXABI() != CXXABI_Microsoft all over the place, please introduce an isItaniumABI() predicate. Also, consider caching it as a field of VTableContext. + assert(!isMicrosoft && + "Implicit virtual dtors are not yet supported in MS ABI"); + This is not an appropriate use of assert. Otherwise this looks fine. John. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
