LGTM, but you probably need someone else to review it.
================
Comment at: lib/AST/ASTDumper.cpp:541
@@ -445,1 +540,3 @@
+ setMoreChildren(HasDeclContext);
+ if (HasAttrs) {
for (AttrVec::const_iterator I = D->getAttrs().begin(),
----------------
Richard Trieu wrote:
> Philip Craig wrote:
> > I think this test is some code I forgot to delete. The iterator check in
> > the for loop is enough, so no need for this or the hasAttrs() call above.
> I found that hasAttrs() is required. getAttrs() asserts when there is no
> attrs.
Ah yes, it would also need to change to use attr_begin(). Up to you whether you
do that.
http://llvm-reviews.chandlerc.com/D281
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
