Generally looks good. Since we now have the specialization pattern multiple
times, I wonder whether there's a more compact way to write that. I'll try to
come up with something. In the meantime, this looks fine.
================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:386
@@ +385,3 @@
+ }
+ LLVM_OVERRIDE;
+
----------------
Can't that go before the opening curly? (I have no idea about the new cool
override keywords, so I'm curious :)
================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:378
@@ +377,3 @@
+template <typename T, typename ArgT>
+class HasOverloadedOperatorNameMatcher : public SingleNodeMatcherInterface<T> {
+public:
----------------
Please put in a TOOLING_COMPILE_ASSERT that T is one of the supported types?
http://llvm-reviews.chandlerc.com/D494
BRANCH
matchers
ARCANIST PROJECT
clang
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
