No, sorry, I just figured that you would have updated by now. Would you like me to put it back again?
On Mar 12, 2013, at 12:49 PM, Nico Weber <[email protected]> wrote: > Is there urgency to do this? Xcode 4.6 has been out for 2 months, and > upgrading bots takes a while. > > > On Tue, Mar 12, 2013 at 12:39 PM, Bob Wilson <[email protected]> wrote: > Author: bwilson > Date: Tue Mar 12 14:39:19 2013 > New Revision: 176887 > > URL: http://llvm.org/viewvc/llvm-project?rev=176887&view=rev > Log: > Revert r166370 and r166540 now that Xcode 4.6 has been available for a while. > > Those changes were added as a temporary workaround for Xcode 4.5 passing the > -Wno-arc-abi option. Xcode 4.6 does not pass that option so this should no > longer be necessary. > > Modified: > cfe/trunk/include/clang/Basic/DiagnosticGroups.td > cfe/trunk/test/Driver/warning-options.cpp > > Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=176887&r1=176886&r2=176887&view=diff > ============================================================================== > --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original) > +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Tue Mar 12 14:39:19 2013 > @@ -303,8 +303,6 @@ def ImplicitAtomic : DiagGroup<"implicit > def CustomAtomic : DiagGroup<"custom-atomic-properties">; > def AtomicProperties : DiagGroup<"atomic-properties", > [ImplicitAtomic, CustomAtomic]>; > -// FIXME: Remove arc-abi once an Xcode is released that doesn't pass this > flag. > -def : DiagGroup<"arc-abi">; > def ARCUnsafeRetainedAssign : DiagGroup<"arc-unsafe-retained-assign">; > def ARCRetainCycles : DiagGroup<"arc-retain-cycles">; > def ARCNonPodMemAccess : DiagGroup<"arc-non-pod-memaccess">; > > Modified: cfe/trunk/test/Driver/warning-options.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/warning-options.cpp?rev=176887&r1=176886&r2=176887&view=diff > ============================================================================== > --- cfe/trunk/test/Driver/warning-options.cpp (original) > +++ cfe/trunk/test/Driver/warning-options.cpp Tue Mar 12 14:39:19 2013 > @@ -3,11 +3,6 @@ > // RUN: %clang -### -Wlarge-by-value-copy=128 %s 2>&1 | FileCheck > -check-prefix=LARGE_VALUE_COPY_JOINED %s > // LARGE_VALUE_COPY_JOINED: -Wlarge-by-value-copy=128 > > -// FIXME: Remove this together with -Warc-abi once an Xcode is released that > doesn't pass this flag. > -// RUN: %clang -### -Warc-abi -Wno-arc-abi %s 2>&1 | FileCheck > -check-prefix=ARCABI %s > -// ARCABI-NOT: unknown warning option '-Warc-abi' > -// ARCABI-NOT: unknown warning option '-Wno-arc-abi' > - > // Check that -isysroot warns on nonexistent paths. > // RUN: %clang -### -c -target i386-apple-darwin10 -isysroot /FOO %s 2>&1 | > FileCheck --check-prefix=CHECK-ISYSROOT %s > // CHECK-ISYSROOT: warning: no such sysroot directory: > '{{([A-Za-z]:.*)?}}/FOO' > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
