Hi rsmith,

Currently, it does not influence warnings that are promoted to error by default 
(e.g. -Wstatic-float-init).

I am not entirely sure I am doing the right thing at the right place, so I'd be 
happy about input.

http://llvm-reviews.chandlerc.com/D551

Files:
  lib/Basic/DiagnosticIDs.cpp

Index: lib/Basic/DiagnosticIDs.cpp
===================================================================
--- lib/Basic/DiagnosticIDs.cpp
+++ lib/Basic/DiagnosticIDs.cpp
@@ -471,7 +471,8 @@
 
   // Honor -w, which is lower in priority than pedantic-errors, but higher than
   // -Werror.
-  if (Result == DiagnosticIDs::Warning && Diag.IgnoreAllWarnings)
+  if ((DiagClass <= CLASS_EXTENSION || Result == DiagnosticIDs::Warning) &&
+      Diag.IgnoreAllWarnings)
     return DiagnosticIDs::Ignored;
 
   // If -Werror is enabled, map warnings to errors unless explicitly disabled.
Index: lib/Basic/DiagnosticIDs.cpp
===================================================================
--- lib/Basic/DiagnosticIDs.cpp
+++ lib/Basic/DiagnosticIDs.cpp
@@ -471,7 +471,8 @@
 
   // Honor -w, which is lower in priority than pedantic-errors, but higher than
   // -Werror.
-  if (Result == DiagnosticIDs::Warning && Diag.IgnoreAllWarnings)
+  if ((DiagClass <= CLASS_EXTENSION || Result == DiagnosticIDs::Warning) &&
+      Diag.IgnoreAllWarnings)
     return DiagnosticIDs::Ignored;
 
   // If -Werror is enabled, map warnings to errors unless explicitly disabled.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to