On Apr 15, 2013, at 6:01 PM, Andy Gibbs <[email protected]> wrote:
> Hi,
>
> Attached is a patch implementing #pragma GCC warning and #pragma GCC error by
> extending the implementation of #pragma warning which is already present in
> clang.
>
> Does anyone have any objections to me committing this?
+ PragmaMessageHandler(PPCallbacks::PragmaMessageKind Kind,
+ StringRef Namespace = StringRef())
+ : PragmaHandler(PragmaKind(Kind) + 7),
This "+7" is a bit too magical. Please turn it into a separate function with a
switch.
Otherwise, LGTM!
- Doug
> Thanks
>
> Andy
>
> <pragma-message-extension.diff>_______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
