================ Comment at: include/clang/Tooling/Tooling.h:203 @@ +202,3 @@ + // + /// TODO: Function is deprecated. Use (clear/append)ArgumentsAdjuster instead. + /// Remove it once all callers are gone. ---------------- In llvm we use FIXME instead of TODO.
================ Comment at: include/clang/Tooling/Tooling.h:209 @@ +208,3 @@ + /// + /// \param Adjuster Command line arguments adjuster. + void appendArgumentsAdjuster(ArgumentsAdjuster *Adjuster); ---------------- This seems unnecessary, as it doesn't tell me much. I'd rather put in something like: Each argument adjuster will act as a filter on the output of the previous argument adjuster. (or something similar). ================ Comment at: include/clang/Tooling/Tooling.h:212 @@ +211,3 @@ + + /// \brief Clear the command line arguments adjuster chain + void clearArgumentsAdjusters(); ---------------- Nit: please add '.' at the end of sentences... http://llvm-reviews.chandlerc.com/D914 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
