================
Comment at: unittests/Format/FormatTest.cpp:4890-4891
@@ +4889,4 @@
+ getLLVMStyleWithColumns(35));
+ verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"",
+ getLLVMStyleWithColumns(21));
+ verifyFormat("// Однажды в студёную зимнюю пору...",
----------------
Dmitri Gribenko wrote:
> OK, if we decide to count codepoints for now, please adjust the string length
> then -- it is currently computed as if a double-width character actually
> occupies 2 columns (but the code being tested counts it as one).
>
Well, I think this is not at all what the test was meant to be testing. The
point is that the string contains 22 bytes .. And IMO, it would also be 22
columns with 2-column characters. So it does in fact test the right thing.
But I also don't see harm in using getLLVMStyleWithColumns(12). If anything it
makes the test stricter..
http://llvm-reviews.chandlerc.com/D918
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
