Re: [PATCH] Make clang tools ignore -fcolor-diagnostics and -fdiagnostics-color retrieved from the compilation database.

[Manuel Klimek]

  lg


================
Comment at: lib/Tooling/ArgumentsAdjusters.cpp:30
@@ +29,3 @@
+  AdjustedArgs.reserve(Args.size() + 1);
+  for (size_t i = 0, e = Args.size(); i < e; ++i) {
+    StringRef Arg = Args[i];
----------------
Very small nit: I think i != e is slightly more common in llvm.

================
Comment at: lib/Tooling/ArgumentsAdjusters.cpp:29
@@ +28,3 @@
+  CommandLineArguments AdjustedArgs;
+  AdjustedArgs.reserve(Args.size() + 1);
+  for (size_t i = 0, e = Args.size(); i < e; ++i) {
----------------
I'm usually against reserve calls unless we think this really affects 
performance.


http://llvm-reviews.chandlerc.com/D917

BRANCH
  svn

ARCANIST PROJECT
  clang
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits