I'm building a Clang tool and would like to compile it with
-Wimplicit-fallthrough turned on. However, include/clang/Sema/Sema.h
contains an unannotated implicit fallthrough. Since there doesn't seem
to be a generally-agreed-upon standard annotation for this yet and
because I would prefer to avoid wrapping the include with pragmas to
turn the warning off, I suggest changing the code slightly to avoid
the problem.

I attempted to build the rest of Clang with the warning turned on.
Most of the uncommented fallthroughs look benign, save for one in
lib/Driver/ToolChains.cpp; I don't think aarch64 should fall through
to check for mips libraries if aarch64 isn't available.

Attachment: fix-toolchains.patch
Description: Binary data

Attachment: sema-fallthrough.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to