LGTM with a small nit.
  I am not sure if I have the authority to approve it though.


================
Comment at: lib/Driver/Tools.cpp:1773
@@ +1772,3 @@
+                            ArgStringList &CmdArgs) {
+  if (!Args.hasArg(options::OPT_shared)) {
+    addSanitizerRTLinkFlagsLinux(TC, Args, CmdArgs, "dfsan", true);
----------------
remove { }

================
Comment at: docs/DataFlowSanitizerDesign.rst:1
@@ +1,2 @@
+DataFlowSanitizer Design Document
+=================================
----------------
It might be good to give an example use case, the one you replied in the mail 
discussion:
 "take a large application and use this instrumentation as a tool to help 
monitor how data flows from its inputs (sources) to its outputs (sinks)". 
You could add this later. 


http://llvm-reviews.chandlerc.com/D966
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to