Thought so, makes sense. Cheers, Renato On Jun 19, 2013 3:11 PM, "Keith Walker" <[email protected]> wrote:
> Renato,**** > > ** ** > > I added the field to make it possible to check that the member was > generated in the debug information as the issue being fixed was members > not being generated.**** > > ** ** > > I also added an incomplete struct definition (struct c) to make sure that > it was generated in the debug information as a declaration (ie, an > incomplete structure type).**** > > ** ** > > Keith**** > > ** ** > > *From:* Renato Golin [mailto:[email protected]] > *Sent:* 19 June 2013 14:49 > *To:* Keith Walker > *Cc:* Clang Commits > *Subject:* Re: [PATCH] Output debug information for structure members > only referenced by a pointer or typedef**** > > ** ** > > On 19 June 2013 13:34, Keith Walker <[email protected]> wrote:**** > > struct b { > + int j; > };**** > > ** ** > > Hi Keith,**** > > ** ** > > Why add the field here?**** > > ** ** > > ** ** > > + bool Declaration = isa<RecordType>(PointeeTy); > + return getOrCreateType(PointeeTy, Unit, Declaration);**** > > ** ** > > This looks ok to me, but I haven't touched de debug info in years.**** > > ** ** > > cheers,**** > > --renato**** > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
