Thanks, committing since this is pretty simple.

================
Comment at: lib/AST/MicrosoftMangle.cpp:137
@@ -136,3 +136,3 @@
                           const TemplateArgumentList &TemplateArgs);
-
+  void mangleTemplateArg(const TemplateDecl *TD, const TemplateArgument &TA, 
int i);
 };
----------------
Timur Iskhodzhanov wrote:
> Can you come up with a more descriptive name?
> e.g. OrdinalNumber?
Sure, ArgIndex.

================
Comment at: lib/AST/MicrosoftMangle.cpp:878
@@ +877,3 @@
+  case TemplateArgument::Pack:
+    // MSVC 2013 is the first version to support variadic templates, and it
+    // doesn't do anything special to mangle template parameter packs.
----------------
Timur Iskhodzhanov wrote:
> I think it's safe to remove this comment
I want to keep it because it's a divergence from Itanium, which has a special 
character code.


http://llvm-reviews.chandlerc.com/D1077

COMMIT
  http://llvm-reviews.chandlerc.com/rL185454
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to