On Mon, Jul 15, 2013 at 4:25 PM, Samuel Benzaquen <[email protected]> wrote:
> > > ================ > Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:1441 > @@ +1440,3 @@ > +/// \code Getter<OuterT>::value() \endcode returns a > +/// \code InnerTBase (OuterT::*)() \endcode, which is used to adapt a \c > OuterT > +/// object into a \c InnerT > ---------------- > Manuel Klimek wrote: > > I think it's quite curious for the matchers that InnerTBase is returned > by-value here (as that strongly limits what matchers this can be used > with). I assume that was intentional? > > I'm wondering whether there's a simpler solution hidden somewhere... > This class replaces the two classes that were being used for QualType and > TypeLoc. Both of these are passed by value. I made it as generic as I > needed for this specific change. > Makes sense. > > > http://llvm-reviews.chandlerc.com/D1023 > > BRANCH > type_traversal > > ARCANIST PROJECT > clang >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
