Alexey, Why has this not been committed? Doug had said, "This LGTM. Go ahead, and we can talk about the structured block checking separately." -- so please do. The fixes that Wei suggested seem to be all minor corrections (undoubtedly good to have), and don't invalidate that approval. In short, unless there is something else on which you'd really like some feedback (in which case, please say so explicitly), let's get this committed and move on :)
Thanks again, Hal ----- Original Message ----- > Fixes after Wei review. > > Hi doug.gregor, gribozavr, hfinkel, > > http://llvm-reviews.chandlerc.com/D572 > > CHANGE SINCE LAST DIFF > http://llvm-reviews.chandlerc.com/D572?vs=2519&id=2543#toc > > Files: > test/OpenMP/parallel_ast_print.cpp > test/OpenMP/threadprivate_ast_print.cpp > test/OpenMP/parallel_default_messages.cpp > test/OpenMP/threadprivate_messages.cpp > test/OpenMP/parallel_private_messages.cpp > include/clang/Basic/OpenMPKinds.def > include/clang/Basic/StmtNodes.td > include/clang/Basic/OpenMPKinds.h > include/clang/Basic/DiagnosticParseKinds.td > include/clang/Basic/DiagnosticSemaKinds.td > include/clang/Sema/Sema.h > include/clang/AST/StmtOpenMP.h > include/clang/AST/StmtVisitor.h > include/clang/AST/RecursiveASTVisitor.h > include/clang/Parse/Parser.h > include/clang/Serialization/ASTBitCodes.h > include/clang-c/Index.h > tools/libclang/RecursiveASTVisitor.h > tools/libclang/CXCursor.cpp > tools/libclang/CIndex.cpp > lib/Basic/OpenMPKinds.cpp > lib/Sema/TreeTransform.h > lib/Sema/SemaOpenMP.cpp > lib/Sema/SemaAccess.cpp > lib/AST/DeclOpenMP.cpp > lib/AST/Stmt.cpp > lib/AST/StmtPrinter.cpp > lib/AST/StmtProfile.cpp > lib/StaticAnalyzer/Core/ExprEngine.cpp > lib/CodeGen/CGStmt.cpp > lib/Parse/ParseStmt.cpp > lib/Parse/ParseOpenMP.cpp > lib/Serialization/ASTReaderStmt.cpp > lib/Serialization/ASTWriterStmt.cpp > -- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
