Re: [PATCH] FIXME fix: improving diagnostics for template arguments deduction of class templates and explicit specializations

[Richard Smith]

  LGTM


================
Comment at: lib/Sema/SemaOverload.cpp:8448
@@ +8447,3 @@
+  
+  FunctionDecl* Fn = cast<FunctionDecl>(D);
+  
----------------
"*" on the right.

================
Comment at: lib/Sema/SemaOverload.cpp:8493-8495
@@ +8492,5 @@
+TemplateDecl *getDescribedTemplate(Decl *Templated) {
+  if (FunctionDecl* FD = dyn_cast<FunctionDecl>(Templated))
+    return FD->getDescribedFunctionTemplate();
+  else if (CXXRecordDecl* RD = dyn_cast<CXXRecordDecl>(Templated))
+    return RD->getDescribedClassTemplate();
----------------
Likewise.


http://llvm-reviews.chandlerc.com/D1147
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits