On Tue, Aug 20, 2013 at 2:44 PM, Hans Wennborg <[email protected]> wrote:
> On Tue, Aug 20, 2013 at 2:26 PM, Reid Kleckner <[email protected]> wrote: > >> std::string ProgName(llvm::sys::path::stem(ArgVector[0])); > >> + for (size_t i = 0, e = ProgName.length(); i != e; ++i) > >> + ProgName[i] = toLowercase(ProgName[i]); > > > > > > This is modern C++, we can't use for loops, what are we, farmers!? > > std::transform(ProgName.begin(), ProgName.end(), ProgName.begin(), > > ::toLowerCase); > > Sure, I've updated the patch. > > > Also, should we do this transform on non-Windows platforms? > > Yes, I think we should. Mostly because I don't see any reason not to, > and the less platform-specific code, the better. > OK. LGTM > New patch uploaded. >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
