I built and tested this locally, and it works really well! The Visual Studio SDK was necessary for building, thanks for the hint. Maybe add a README with info on prerequisites? The VS SDK for 2012 is available here: http://www.microsoft.com/en-us/download/details.aspx?id=30668
Also, the SVN patch didn't carry the binary files Images.png and Package.ico, so I had to create dummy images, but that should work better from a proper checkout. LGTM. ================ Comment at: tools/clang-format-vs/ClangFormat/PkgCmdID.cs:2 @@ +1,3 @@ +// PkgCmdID.cs +// MUST match PkgCmdID.h + ---------------- I find these comments confusing, I guess they came from a code generator? ================ Comment at: tools/clang-format-vs/ClangFormat/Guids.cs:2 @@ +1,3 @@ +// Guids.cs +// MUST match guids.h +using System; ---------------- I find these comments confusing, I guess they came from a code generator? http://llvm-reviews.chandlerc.com/D1543 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
