[PATCH] New FIXME text for Consumed Analysis

[Christian Wailes]

Hi delesley, aaron.ballman,

Updated some FIXME text to correctly describe the problem and what needs to be 
done to fix it.

http://llvm-reviews.chandlerc.com/D1588

Files:
  test/SemaCXX/warn-consumed-parsing.cpp

Index: test/SemaCXX/warn-consumed-parsing.cpp
===================================================================
--- test/SemaCXX/warn-consumed-parsing.cpp
+++ test/SemaCXX/warn-consumed-parsing.cpp
@@ -6,8 +6,11 @@
 #define RETURN_TYPESTATE(State)  __attribute__ ((return_typestate(State)))
 #define TESTS_UNCONSUMED         __attribute__ ((tests_unconsumed))
 
-// FIXME: This warning is not generated if it appears bellow the AttrTester0
-//        class declaration.  Why?
+// FIXME: This test is here because the warning is issued by the Consumed
+//        analysis, not SemaDeclAttr.  The analysis won't run after an error
+//        has been issued.  Once the attribute propagation for template
+//        instantiation has been fixed, this can be moved somewhere else and 
the
+//        definition can be removed.
 int returnTypestateForUnconsumable() RETURN_TYPESTATE(consumed); // 
expected-warning {{return state set for an unconsumable type 'int'}}
 int returnTypestateForUnconsumable() {
   return 0;

Index: test/SemaCXX/warn-consumed-parsing.cpp
===================================================================
--- test/SemaCXX/warn-consumed-parsing.cpp
+++ test/SemaCXX/warn-consumed-parsing.cpp
@@ -6,8 +6,11 @@
 #define RETURN_TYPESTATE(State)  __attribute__ ((return_typestate(State)))
 #define TESTS_UNCONSUMED         __attribute__ ((tests_unconsumed))
 
-// FIXME: This warning is not generated if it appears bellow the AttrTester0
-//        class declaration.  Why?
+// FIXME: This test is here because the warning is issued by the Consumed
+//        analysis, not SemaDeclAttr.  The analysis won't run after an error
+//        has been issued.  Once the attribute propagation for template
+//        instantiation has been fixed, this can be moved somewhere else and the
+//        definition can be removed.
 int returnTypestateForUnconsumable() RETURN_TYPESTATE(consumed); // expected-warning {{return state set for an unconsumable type 'int'}}
 int returnTypestateForUnconsumable() {
   return 0;

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits