On Tue, Sep 03, 2013 at 06:16:31PM -0700, Richard Smith wrote: > On Tue, Sep 3, 2013 at 5:10 PM, Peter Collingbourne <[email protected]> wrote: > > > Author: pcc > > Date: Tue Sep 3 19:10:25 2013 > > New Revision: 189893 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=189893&view=rev > > Log: > > Add a diagnostic group for the "ignoring (static|inline) keyword on > > explicit template instantiation" warning. > > > > Modified: > > cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td > > cfe/trunk/test/Misc/warning-flags.c > > > > Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td > > URL: > > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=189893&r1=189892&r2=189893&view=diff > > > > ============================================================================== > > --- cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td (original) > > +++ cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Tue Sep 3 > > 19:10:25 2013 > > @@ -616,7 +616,7 @@ def warn_cxx98_compat_extern_template : > > InGroup<CXX98CompatPedantic>, DefaultIgnore; > > def warn_static_inline_explicit_inst_ignored : Warning< > > "ignoring '%select{static|inline}0' keyword on explicit template " > > - "instantiation">; > > + "instantiation">, > > InGroup<DiagGroup<"static-inline-explicit-instantiation">>; > > > > Hmm, shouldn't this be an ExtWarn, not a Warning?
You are probably correct. While we do not implement the selective instantiation aspect of this extension: http://gcc.gnu.org/onlinedocs/gcc/Template-Instantiation.html I am having trouble imagining an (otherwise) conforming program which we would reject (or a non-conforming program which we would accept) because of a lack of support for this aspect of the extension. Thanks, -- Peter _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
