Hi Renato,
A few comments, though I'm just getting aquainted with this code myself.
1) That NEON test probably should be checking for startswith("8") as well as
"7". But you could leave that for me if you want to confine this to v7A
cleanup.
2) It seems to be rather the done thing, but does getDefaultDefinitions do
anything that setting VFP/NEON as subtarget features for the relevant CPUs
in tabglegen wouldn't do? If not, can we kill it?
3) Does test/Driver/arm-mfpu.c help with some of the testing?
Regards,
Bernie
> -----Original Message-----
> From: [email protected] [mailto:cfe-commits-
> [email protected]] On Behalf Of Renato Golin
> Sent: 05 September 2013 11:38
> To: [email protected]
> Cc: [email protected]
> Subject: Re: [PATCH] ARMv7A Cleanup
>
>
> ping?
>
> http://llvm-reviews.chandlerc.com/D1579
> _______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
