I'm not sure. I guess it's fine not to bother.

Jordan


On Sep 5, 2013, at 17:23 , Alexander Kornienko <[email protected]> wrote:

> It's an interesting idea. I'm slightly worried about the need to maintain 
> cross-file consistency though. Is something similar already used in 
> LLVM/clang tests?
> 
> On Sep 6, 2013 2:10 AM, "Jordan Rose" <[email protected]> wrote:
> 
>   Let's drop the CHECK-MACHINE case, but otherwise this looks good.
> 
>   However, if you care about keeping the test files in sync, how about just 
> making this file only contain CHECK lines, and actually compile the original 
> fixit-unicode.c? That allows you to specify the XFAIL properly while avoiding 
> duplication.
> 
> http://llvm-reviews.chandlerc.com/D1607

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to