Seems reasonable here. Go ahead and commit and if we need to we can pull it back out.
-eric On Thu, Sep 5, 2013 at 3:28 AM, Renato Golin <[email protected]> wrote: > LibXML2 config doesn't specify lzma as a dependency, which breaks > cross-compilation builds using new linkers (ld 2.21 or higher). > > There is a bug on libxml2 to fix that, but since it's going to take a > while for things to go round and back, so we should have a harmless addition > of the library until then. > > This breaks Clang's c-index-test cross-build. > > http://llvm-reviews.chandlerc.com/D1604 > > Files: > cmake/config-ix.cmake > > Index: cmake/config-ix.cmake > =================================================================== > --- cmake/config-ix.cmake > +++ cmake/config-ix.cmake > @@ -300,6 +300,10 @@ > find_package(LibXml2) > if (LIBXML2_FOUND) > set(CLANG_HAVE_LIBXML 1) > + if (NOT PC_LIBXML_VERSION VERSION_LESS "2.8.0") > + message(STATUS "Adding LZMA as a dep to XML2 until xml2-config gets > fixed") > + set(LIBXML2_LIBRARIES ${LIBXML2_LIBRARIES} "-llzma") > + endif () > endif () > > include(CheckCXXCompilerFlag) > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
