On Sep 8, 2013, at 10:15 PM, Marshall Clow <[email protected]> wrote:
> The last one (map and multimap) should have been #4. > > -- Marshall > > Marshall Clow Idio Software <mailto:[email protected]> > > A.D. 1517: Martin Luther nails his 95 Theses to the church door and is > promptly moderated down to (-1, Flamebait). > -- Yu Suzuki > <ish2210-5.patch>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits Got a test failure under -std=c++1y: iter_iter_alloc.pass.cpp:73:13: error: no template named 'min_allocator'; did you mean 'test_allocator'? typedef min_allocator<V> A; ^~~~~~~~~~~~~ test_allocator ./../../../test_allocator.h:27:37: note: 'test_allocator' declared here template <class U> friend class test_allocator; ^ 1 error generated. /Users/hhinnant/Development/libcxx/test/containers/associative/multiset/multiset.cons/iter_iter_alloc.pass.cpp failed to compile Compile line was: totclang++ -std=c++1y -stdlib=libc++ -I/Users/hhinnant/Development/libcxx/test/support -I/Users/hhinnant/Development/libcxx/include -L/Users/hhinnant/Development/libcxx/lib iter_iter_alloc.pass.cpp failed 1 tests in /Users/hhinnant/Development/libcxx/test/containers/associative/multiset/multiset.cons Should not be hard to fix. It is a test error, not a libc++ error. Also _Compare() was used in 4 places where I think we should use value_compare() instead. This is just an aesthetic change but it makes the coding style consistent throughout the library. Please commit with these changes. Thanks, Howard _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
