================
Comment at: docs/ModernizerUsage.rst:49
@@ +48,3 @@
+
+ ``clang-modernize -p=<build-path> -include=/``
+
----------------
I would discourage saying `-include=/` since that implies changes will be made
to STL libraries (in /usr/include) as well in common cases. Instead, say
something like `-include=<project_root>` which satisfies both Unix and Windows
paths.
================
Comment at: clang-modernize/tool/ClangModernize.cpp:351
@@ +350,3 @@
+ if (!Compilations) {
+ llvm::errs() << argv[0] << ": " << ErrorMessage << "\n";
+ return 1;
----------------
Use `llvm::sys::path::filename(argv[0])` to cut down the path incase the user
is using the full path to clang-modernize.
================
Comment at: clang-modernize/tool/ClangModernize.cpp:365
@@ +364,3 @@
+ if (GlobalOptions.ModifiableFiles.isIncludeListEmpty()) {
+ llvm::errs() << argv[0] << ": Use -include to indicate which files of "
+ << "the compilatiion database to transform.\n";
----------------
Use `llvm::sys::path::filename(argv[0])`.
================
Comment at: clang-modernize/tool/ClangModernize.cpp:376
@@ +375,3 @@
+ if (Sources.empty()) {
+ llvm::errs() << argv[0] << ": Could not determine sources to transform.\n";
+ return 1;
----------------
Use `llvm::sys::path::filename(argv[0])`
================
Comment at: docs/ModernizerUsage.rst:43
@@ -42,1 +42,3 @@
+ Files in the compilation database could be transformed if no sources are
+ provided and file paths are explicitly included using ``-include`` or
----------------
Files in the compilation database **that can be** transformed ...
http://llvm-reviews.chandlerc.com/D1517
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
