Committed r190684. -----Original Message----- From: Michele Scandale [mailto:[email protected]] Sent: 12 September 2013 14:09 To: David Tweed Cc: Mon Ping Wang; [email protected]; [email protected]; Tanya Lattner; Eli Friedman Subject: Re: OpenCL address space and mangling
On 09/12/2013 02:31 PM, David Tweed wrote: > Hi Michele, > > This patch LGTM. Assuming you'd still like someone to commit it on your > behalf, I'll leave it for a day in case > anyone else has any comments or issues, but can commit it for you end of > tomorrow if nothing comes up. > > Thanks for working on this, Yes, if you can commit it I would appreciate :-). I agree with your plan. Thanks again. Regards, -Michele > Cheers, > Dave > > -----Original Message----- > From: Michele Scandale [mailto:[email protected]] > Sent: 12 September 2013 12:35 > To: David Tweed > Cc: Mon Ping Wang; [email protected]; [email protected]; Tanya > Lattner; Eli Friedman > Subject: Re: OpenCL address space and mangling > > On 09/11/2013 11:55 AM, David Tweed wrote: >> while I think most people agree with the direction things are going there >> look to still >> be some fiddly details. As one instance, when I run this on a standard OSS >> LLVM build I get >> a new test failure in test/CodeGenOpenCL/local.cl. Since behaviour is being >> made more sophisticated, it seems >> it would be good to have add some tests that verify the new behaviour so we >> can detect any >> modifications that change it. But the patch looks to be progressing. > > Hi David, > > I've fixed the test and added another test specific for mangling checking. To > simplify testing I've added a command line option (similar to > -ffake-address-space-map). > > In attachment the new version of the patch. > > Thanks in advance. > > Best Regards, > Michele > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 > ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2548782 > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
