================ Comment at: lib/AST/Decl.cpp:2213 @@ +2212,3 @@ + + // Even though ee aren't really targeting Win32 if we are freestanding, + // semantic analysis for these functions remain the same. ---------------- s/ ee / we /
================ Comment at: lib/AST/Decl.cpp:2214 @@ +2213,3 @@ + // Even though ee aren't really targeting Win32 if we are freestanding, + // semantic analysis for these functions remain the same. + ---------------- *remains ================ Comment at: lib/AST/Decl.cpp:2216-2218 @@ +2215,5 @@ + + // Win32 entry points only exist on win32 targets. + if (TUnit->getASTContext().getTargetInfo().getTriple().getOS() != + llvm::Triple::Win32) + return false; ---------------- Should this be isOSWindows()? How should we behave for MinGW32 and Cygwin? ================ Comment at: lib/Sema/SemaOverload.cpp:985 @@ +984,3 @@ + if (New->isWin32EntryPoint()) + return false; + ---------------- Overindented. http://llvm-reviews.chandlerc.com/D1683 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
