On 09/19/2013 06:41 PM, Eric Christopher wrote:
On Thu, Sep 19, 2013 at 8:31 AM, Adrian Prantl <[email protected]> wrote:
On Sep 18, 2013, at 11:29 PM, Tobias Grosser <[email protected]> wrote:
On 09/19/2013 12:18 AM, Adrian Prantl wrote:
Author: adrian
Date: Wed Sep 18 17:18:17 2013
New Revision: 190962
URL: http://llvm.org/viewvc/llvm-project?rev=190962&view=rev
Log:
get rid of extra parentheses.
Hi Adrian,
I have the feeling this change is contrary to what people normally do in LLVM.
Specifically, either people have parenthesis on all branches or
we use none at all.
You might want to discuss this with Eric :-)
Normally I'd point you at the coding style doc which should have this,
however, it apparently doesn't. In general for single line statements
after a conditional we don't have braces - except where we would need
to quiet a dangling else warning. I'm curious where you've seen
contrary (except apparently some bad cases in the coding style doc).
I looked there too, but did not find any reference either.
For some reason I had the impression what I was asking for is common
practice. There is also a recent commit where Craig added braces, which
seems to match the change we discuss here:
r190982 - Use curly braces all the way through long if/else chain for
consistency and readability.
On the other hand, I was looking at the LLVM source files and there does
not seem to be a consistent pattern (I did not count which style is more
comment). As we both seems to mention this in a code review, it might be
useful to clarify it in the coding style document. I have no strong
opinion in either direction.
Cheers,
Tobias
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
