On Oct 6, 2013, at 1:03 PM, Howard Hinnant <[email protected]> wrote:
> On Oct 3, 2013, at 3:42 PM, Nick Kledzik <[email protected]> wrote: > >> >> On Oct 3, 2013, at 10:47 AM, Dmitri Gribenko <[email protected]> wrote: >> >>> On Thu, Oct 3, 2013 at 10:36 AM, Nick Kledzik <[email protected]> wrote: >>>> Years ago Apple wrote its own unwinder for MacOSX and iOS. To make >>>> libcxxabi complete, Apple has decided the source code for its unwinder can >>>> be contributed to the open source LLVM libcxxabi project, with a dual >>>> licensed under LLVM and MIT license. >>> >>> Great news! >>> >>>> So, I’ve spent some time cleaning up the sources to make them conform with >>>> LLVM style >>> >>> Not a review, just style comments: >>> - please use three slashes for documentation comments that come before >>> function declarations/definitions >>> - some files contain tabs (for example, src/Unwind/config.h) >>> - some files contain trailing whitespace >>> - src/Unwind/UnwindRegistersRestore.s has some broken ASCII art >> >> I’ve fixed those issues in this patch. >> >> <libunwind2.patch> > > Thanks! Please commit. Committed in r192136 -Nick _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
