Hi Hao, This looks fine now. Thanks for working on it.
> I've refactored the patch and added it again: > http://llvm-reviews.chandlerc.com/D1885. You can add a new diff to an existing issue in Phabricator: 1. Click "Create Diff" as normal 2. Select the file/paste it. OK. 3. Change the "Attach to" dropdown to an existing set. This is good because it lets people immediately see what's changed between the two diffs from the UI. Cheers. Tim. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
