> shouldMangleDeclNameImpl can be shouldMangleCXXName, following the same
> logic as mangleName.

Done.

> This AttributedType handling isn't necessary, use T->castAs<FunctionType>()
> instead of cast<>() to look through the type sugar.

This is awesome. Done.

> +  return mangleCXXName(D, Out);
>
> We shouldn't apply the stdcall or fastcall manglings to C++ symbols.  You
> should check if we should mangle this as a C++ name first, and after that
> see if we need to apply C manglings.

Thanks. I noticed that we were not quoting the mingw case. I have
fixed the logic and added a c++ testcase.

Cheers,
Rafael

Attachment: t.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to