On Tue, Oct 22, 2013 at 10:08 AM, Diego Novillo <[email protected]> wrote:
> On Tue, Oct 22, 2013 at 1:06 PM, Chandler Carruth <[email protected]> > wrote: > > My only objection to this patch is the use of the word "auto". ;] While I > > know there is some historical precedent, I think that if this is going > into > > mainline Clang, it would be worthwhile to strive for a more descriptive > > name. '-fsample-profile'? Other ideas? > > It cannot be 'sample'. This option will take all kinds of profiles > that will be treated separately in the backend according to their > nature. > I'm surprised -- I expected this to essentially only be used with sample-based profiles? Bob seemed to have a different architecture in mind for other profile sources? > > We need something generic here. If this is going to be something generic, we should have some input from Bob as well at least. And then the flag name it seems should be "-fprofile" or "-fprofile-file" or "-fprofile-input".... > What's the problem with "auto". Does > it have a different connotation? There isn't actually anything automatic about it? The compiler doesn't run the program while compiling it to produce a profile and then use that to re-compile.... ;]
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
