Done & Submitted as r204913

On Thu, Mar 27, 2014 at 11:44 AM, Daniel Jasper <[email protected]> wrote:

>
>
> ================
> Comment at: lib/Format/TokenAnnotator.cpp:48
> @@ +47,3 @@
> +    Contexts.back().InTemplateArgument =
> +        Left->Previous != NULL &&
> Left->Previous->Tok.isNot(tok::kw_template);
> +
> ----------------
> I think, this deserves a comment. After all, even in template<...> we are
> in a template argument, just not in one that concerns us. Or maybe, this is
> a matter of getting the names right. Is a template argument the same as a
> template parameter? Or is one used at the definition and one at the
> declaration?
>
>
> http://llvm-reviews.chandlerc.com/D3187
>
> BRANCH
>   fix-template-bool
>
> ARCANIST PROJECT
>   clang
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to