On Wed, Mar 26, 2014 at 1:30 AM, Timur Iskhodzhanov <[email protected]>wrote:
> > 2014-03-25 22:33 GMT+04:00 Reid Kleckner <[email protected]>: > > --- cfe/trunk/lib/AST/VTableBuilder.cpp (original) >> +++ cfe/trunk/lib/AST/VTableBuilder.cpp Tue Mar 25 13:33:27 2014 >> @@ -3210,6 +3210,8 @@ void MicrosoftVTableContext::computeVTab >> // morally virtual bases. >> for (const auto &I : Base->vbases()) >> VBasesSeen.insert(I.getType()->getAsCXXRecordDecl()); >> + if (I.isVirtual()) >> + VBasesSeen.insert(Base); >> } >> > > Wow, that revealed that we have a variable name shadowing going on here! > Fixed in r204787. > Yes, when using the new for each loop syntax, I really prefer using meaningful names instead of I. I think we've only been using I for iterators and indices because they're this cruddy little implementation detail that we'd rather skip over and forget about. :) > I also kinda think the if() is more logical/readable to go before for(). > WDYT? > Sure.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
