> On May 19, 2014, at 15:51, Alp Toker <a...@nuanti.com> wrote:
> 
> -  Diags->setDiagnosticMapping(diag::err_arcmt_nsalloc_realloc,
> -                              NoNSAllocReallocError ? diag::MAP_WARNING
> -                                                    : diag::MAP_ERROR,
> -                              SourceLocation());
> +  if (NoNSAllocReallocError)
> +    Diags->setDiagnosticMapping(diag::warn_arcmt_nsalloc_realloc,
> +                                diag::MAP_IGNORE, SourceLocation());
> 

This changes the behavior of the existing flag from (effectively) -Wno-error= 
to -Wno-. I don't think we should do that—any existing tools of ours that rely 
on the frontend flag probably still want the warning, and new tools should just 
use -W*.

Jordan
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to